[ovs-dev] [PATCH] ofproto-dpif: Fix check for 802.1Q header in commit_odp_actions().

Ben Pfaff blp at nicira.com
Mon Sep 12 19:17:03 UTC 2011


On Mon, Sep 12, 2011 at 11:21:25AM -0700, Pravin Shelar wrote:
> On Mon, Sep 12, 2011 at 10:50 AM, Ben Pfaff <blp at nicira.com> wrote:
> > The 'vlan_tci' member of struct flow has value 0, not OFP_VLAN_NONE, when
> > there is no 802.1Q header.
> >
> > Fixes a problem introduced in commit d9065a90b6b "datapath: VLAN actions
> > should use push/pop semantics."
> >
> > Found by sparse.
> >
> > CC: Pravin Shelar <pshelar at nicira.com>
> >
> looks good.

Thanks, I pushed it.



More information about the dev mailing list