[ovs-dev] [PATCH] ovs-vsctl: Improve usage message.

Ben Pfaff blp at nicira.com
Thu Sep 15 20:23:20 UTC 2011


On Thu, Sep 15, 2011 at 01:09:28PM -0700, Ethan Jackson wrote:
> > + ?get-controller BRIDGE ? ? ?print all controller(s) for BRIDGE\n\
> > + ?del-controller BRIDGE ? ? ?delete all controllers for BRIDGE\n\
> > + ?set-controller BRIDGE TARGET... ?set the controller(s) for BRIDGE\n\
> 
> This seems fine, the wording is not self consistent though.  Perhaps
> something like this?
> 
> print the controller(s) ...
> delete the controller(s) ...
> set the controller(s) ...

I was following the precedent set for the manager commands.

Revised version follows.

--8<--------------------------cut here-------------------------->8--

From: Ben Pfaff <blp at nicira.com>
Date: Thu, 15 Sep 2011 13:22:05 -0700
Subject: [PATCH] ovs-vsctl: Improve usage message.

Bug #7332.
Reported-by: Gordon Good <ggood at nicira.com>
---
 AUTHORS               |    1 +
 utilities/ovs-vsctl.c |   10 +++++-----
 2 files changed, 6 insertions(+), 5 deletions(-)

diff --git a/AUTHORS b/AUTHORS
index 44311ff..eefffee 100644
--- a/AUTHORS
+++ b/AUTHORS
@@ -64,6 +64,7 @@ DK Moon                 dkmoon at nicira.com
 Gaetano Catalli         gaetano.catalli at gmail.com
 Ghanem Bahri            bahri.ghanem at gmail.com
 Giuseppe de Candia      giuseppe.decandia at gmail.com
+Gordon Good             ggood at nicira.com
 Gregor Schaffrath       grsch at net.t-labs.tu-berlin.de
 Hassan Khan             hassan.khan at seecs.edu.pk
 Hector Oron             hector.oron at gmail.com
diff --git a/utilities/ovs-vsctl.c b/utilities/ovs-vsctl.c
index 573c948..5f3b7f0 100644
--- a/utilities/ovs-vsctl.c
+++ b/utilities/ovs-vsctl.c
@@ -504,16 +504,16 @@ Interface commands (a bond consists of multiple interfaces):\n\
   iface-to-br IFACE           print name of bridge that contains IFACE\n\
 \n\
 Controller commands:\n\
-  get-controller BRIDGE      print the controller for BRIDGE\n\
-  del-controller BRIDGE      delete the controller for BRIDGE\n\
-  set-controller BRIDGE TARGET  set the controller for BRIDGE to TARGET\n\
+  get-controller BRIDGE      print the controller(s) for BRIDGE\n\
+  del-controller BRIDGE      delete the controllers for BRIDGE\n\
+  set-controller BRIDGE TARGET...  set the controller(s) for BRIDGE\n\
   get-fail-mode BRIDGE       print the fail-mode for BRIDGE\n\
   del-fail-mode BRIDGE       delete the fail-mode for BRIDGE\n\
   set-fail-mode BRIDGE MODE  set the fail-mode for BRIDGE to MODE\n\
 \n\
 Manager commands:\n\
-  get-manager                print all manager(s)\n\
-  del-manager                delete all manager(s)\n\
+  get-manager                print the manager(s)\n\
+  del-manager                delete the manager(s)\n\
   set-manager TARGET...      set the list of manager(s) to TARGET(s)\n\
 \n\
 SSL commands:\n\
-- 
1.7.4.4




More information about the dev mailing list