[ovs-dev] [PATCH] ovs-vsctl: Improve usage message.

Ethan Jackson ethan at nicira.com
Thu Sep 15 22:13:24 UTC 2011


haha this is fine.

Ethan

On Thu, Sep 15, 2011 at 13:31, Ben Pfaff <blp at nicira.com> wrote:
> On Thu, Sep 15, 2011 at 01:24:52PM -0700, Ethan Jackson wrote:
>> > + ?del-controller BRIDGE ? ? ?delete the controllers for BRIDGE\n\
>> > + ?set-controller BRIDGE TARGET... ?set the controller(s) for BRIDGE\n\
>>
>> Looks good,
>>
>> I think the del-controller needs parens around it's s.  I may be wrong though.
>
> Let's try a gedankenexperiment.  Suppose I hand you a flyswatter and
> say, "Ethan, go swat all the flies over in the next room."  You walk
> into the next room and observe that there is exactly one fly in the
> room.  What do you do? (a) come back and say that, sorry, there's only
> one fly, or (b) swat the fly?
>
> I think it's OK without parentheses.  Actually I think they all are.
>
> Here's v3:
>
> --8<--------------------------cut here-------------------------->8--
>
> From bc62b3d2eb77fe795c9a35c9f91e6a7840879266 Mon Sep 17 00:00:00 2001
> From: Ben Pfaff <blp at nicira.com>
> Date: Thu, 15 Sep 2011 13:30:18 -0700
> Subject: [PATCH] ovs-vsctl: Improve usage message.
>
> Bug #7332.
> Reported-by: Gordon Good <ggood at nicira.com>
> ---
>  AUTHORS               |    1 +
>  utilities/ovs-vsctl.c |   12 ++++++------
>  2 files changed, 7 insertions(+), 6 deletions(-)
>
> diff --git a/AUTHORS b/AUTHORS
> index 44311ff..eefffee 100644
> --- a/AUTHORS
> +++ b/AUTHORS
> @@ -64,6 +64,7 @@ DK Moon                 dkmoon at nicira.com
>  Gaetano Catalli         gaetano.catalli at gmail.com
>  Ghanem Bahri            bahri.ghanem at gmail.com
>  Giuseppe de Candia      giuseppe.decandia at gmail.com
> +Gordon Good             ggood at nicira.com
>  Gregor Schaffrath       grsch at net.t-labs.tu-berlin.de
>  Hassan Khan             hassan.khan at seecs.edu.pk
>  Hector Oron             hector.oron at gmail.com
> diff --git a/utilities/ovs-vsctl.c b/utilities/ovs-vsctl.c
> index 573c948..df5150f 100644
> --- a/utilities/ovs-vsctl.c
> +++ b/utilities/ovs-vsctl.c
> @@ -504,17 +504,17 @@ Interface commands (a bond consists of multiple interfaces):\n\
>   iface-to-br IFACE           print name of bridge that contains IFACE\n\
>  \n\
>  Controller commands:\n\
> -  get-controller BRIDGE      print the controller for BRIDGE\n\
> -  del-controller BRIDGE      delete the controller for BRIDGE\n\
> -  set-controller BRIDGE TARGET  set the controller for BRIDGE to TARGET\n\
> +  get-controller BRIDGE      print the controllers for BRIDGE\n\
> +  del-controller BRIDGE      delete the controllers for BRIDGE\n\
> +  set-controller BRIDGE TARGET...  set the controllers for BRIDGE\n\
>   get-fail-mode BRIDGE       print the fail-mode for BRIDGE\n\
>   del-fail-mode BRIDGE       delete the fail-mode for BRIDGE\n\
>   set-fail-mode BRIDGE MODE  set the fail-mode for BRIDGE to MODE\n\
>  \n\
>  Manager commands:\n\
> -  get-manager                print all manager(s)\n\
> -  del-manager                delete all manager(s)\n\
> -  set-manager TARGET...      set the list of manager(s) to TARGET(s)\n\
> +  get-manager                print the managers\n\
> +  del-manager                delete the managers\n\
> +  set-manager TARGET...      set the list of managers to TARGET...\n\
>  \n\
>  SSL commands:\n\
>   get-ssl                     print the SSL configuration\n\
> --
> 1.7.4.4
>
>



More information about the dev mailing list