[ovs-dev] [notifier 2/2] notifiers: Create and destroy nln_notifiers.

Ethan Jackson ethan at nicira.com
Thu Sep 15 23:17:27 UTC 2011


> EINVAL is pretty generic.  Is there something lower down in the stack
> that will log the actual error should one occur?

Yes, nln_notifier_create() logs.

Also, only two callers payed attention to the error, one of those will
be ignoring it in a future patch.  The EINVAL makes me a tad
uncomfortable, but I think it's probably fine.

Thanks for the review

Ethan



More information about the dev mailing list