[ovs-dev] [PATCH v2] Always use generic stats for devices (vports)
Pravin Shelar
pshelar at nicira.com
Fri Sep 16 02:40:01 UTC 2011
On Thu, Sep 15, 2011 at 6:37 PM, Jesse Gross <jesse at nicira.com> wrote:
> On Thu, Sep 15, 2011 at 6:17 PM, Pravin Shelar <pshelar at nicira.com> wrote:
>> diff --git a/include/openvswitch/datapath-protocol.h b/include/openvswitch/datapath-protocol.h
>> index 5d765b1..3c79c0f 100644
>> --- a/include/openvswitch/datapath-protocol.h
>> +++ b/include/openvswitch/datapath-protocol.h
>> struct ovs_vport_stats {
>> - uint64_t rx_packets; /* total packets received */
>> - uint64_t tx_packets; /* total packets transmitted */
>> - uint64_t rx_bytes; /* total bytes received */
>> - uint64_t tx_bytes; /* total bytes transmitted */
>> - uint64_t rx_errors; /* bad packets received */
>> - uint64_t tx_errors; /* packet transmit problems */
>> - uint64_t rx_dropped; /* no space in linux buffers */
>> - uint64_t tx_dropped; /* no space available in linux */
>> + uint64_t rx_packets; /* total packets received */
>> + uint64_t tx_packets; /* total packets transmitted */
>> + uint64_t rx_bytes; /* total bytes received */
>> + uint64_t tx_bytes; /* total bytes transmitted */
>> + uint64_t rx_errors; /* bad packets received */
>> + uint64_t tx_errors; /* packet transmit problems */
>> + uint64_t rx_dropped; /* no space in linux buffers */
>> + uint64_t tx_dropped; /* no space available in linux */
>> };
>
> I was actually referring to the spaces before the type when I
> mentioned tabs. (I know that the file isn't consistent but it's
> supposed to be tabs.)
>
> Other than that, this looks good. I'm assuming that you'll squash it
> with the previous patch. The combined result:
> Acked-by: Jesse Gross <jesse at nicira.com>
>
Pushed to master.
Thanks.
More information about the dev
mailing list