[ovs-dev] [python idl 02/16] python: Avoid "unused parameter" warnings from pychecker.

[Ethan Jackson]

> -    def __parse_end(self, token, string):
> +    def __parse_end(self, _, dummy):

According to the style guide you can prepend a variable with
"unused_".  In my experimentation pychecker respects that.  For this
reason I think this would be clearer as:

def __parse_end(self, _, unused_string):

or even better:

def __parse_end(self, unused_token, unused_string)

Do either of the above prototypes pychecker for you?

Ethan


>         self.__error("trailing garbage at end of input")
>     def __parse_object_init(self, token, string):
>         if token == '}':
> @@ -391,14 +391,14 @@ class Parser(object):
>             self.parse_state = Parser.__parse_object_colon
>         else:
>             self.__error("syntax error parsing object expecting string")
> -    def __parse_object_colon(self, token, string):
> +    def __parse_object_colon(self, token, _):
>         if token == ":":
>             self.parse_state = Parser.__parse_object_value
>         else:
>             self.__error("syntax error parsing object expecting ':'")
>     def __parse_object_value(self, token, string):
>         self.__parse_value(token, string, Parser.__parse_object_next)
> -    def __parse_object_next(self, token, string):
> +    def __parse_object_next(self, token, _):
>         if token == ",":
>             self.parse_state = Parser.__parse_object_name
>         elif token == "}":
> @@ -412,7 +412,7 @@ class Parser(object):
>             self.__parse_array_value(token, string)
>     def __parse_array_value(self, token, string):
>         self.__parse_value(token, string, Parser.__parse_array_next)
> -    def __parse_array_next(self, token, string):
> +    def __parse_array_next(self, token, _):
>         if token == ",":
>             self.parse_state = Parser.__parse_array_value
>         elif token == "]":
> --
> 1.7.4.4
>
> _______________________________________________
> dev mailing list
> dev at openvswitch.org
> http://openvswitch.org/mailman/listinfo/dev
>