[ovs-dev] [PATCH] datapath-protocol: vport_stats types are unsigned.

Pravin Shelar pshelar at nicira.com
Mon Sep 19 23:21:31 UTC 2011


On Mon, Sep 19, 2011 at 4:14 PM, Jesse Gross <jesse at nicira.com> wrote:
> The 'u' in uint64_t apparently got clipped off of the tx_dropped
> member of struct vport_stats in between review and push, incorrectly
> making this a signed type.
>
> CC: Pravin Shelar <pshelar at nicira.com>
> Signed-off-by: Jesse Gross <jesse at nicira.com>
> ---
>  include/openvswitch/datapath-protocol.h |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/include/openvswitch/datapath-protocol.h b/include/openvswitch/datapath-protocol.h
> index 8ed1c7f..fc7cc1f 100644
> --- a/include/openvswitch/datapath-protocol.h
> +++ b/include/openvswitch/datapath-protocol.h
> @@ -143,7 +143,7 @@ struct ovs_vport_stats {
>        uint64_t   rx_errors;           /* bad packets received         */
>        uint64_t   tx_errors;           /* packet transmit problems     */
>        uint64_t   rx_dropped;          /* no space in linux buffers    */
> -       int64_t   tx_dropped;           /* no space available in linux  */
> +       uint64_t   tx_dropped;          /* no space available in linux  */
>  };
>
>  /* Logical ports. */
> --
> 1.7.4.1
>

looks good.

Acked-by: Pravin Shelar <pshelar at nicira.com>



More information about the dev mailing list