[ovs-dev] [PATCH] ovs-bugtool: Use RUNDIR macro for ovs-appctl target.

[Justin Pettit]

On Sep 23, 2011, at 3:35 PM, Ben Pfaff wrote:

> On Fri, Sep 23, 2011 at 03:32:31PM -0700, Justin Pettit wrote:
>>                 cmd_output(CAP_NETWORK_STATUS,
>> -                           [OVS_APPCTL, '-t', '/var/run/ovs-vswitchd.%s.ctl' % vspid, '-e' 'bond/show %s' % b],
>> +                           [OVS_APPCTL, '-t', '@RUNDIR@/ovs-vswitchd.%s.ctl' % vspid, '-e' 'bond/show %s' % b],
>>                            'ovs-appctl-bond-show-%s.out' % b)
> 
> The commit message implies (to my mind) that this is just a nit that
> we are correcting, but in fact it's a bug fix because @RUNDIR@ isn't
> just /var/run, it's actually /var/run/openvswitch, and the latter is
> where these files actually live.
> 
> So it looks good to me but I'd like the commit message to be improved.

Yes, I was being lazy.  :-)

Okay, I updated the comment and pushed it.  I also pulled it into "branch-1.2" and pushed that.

--Justin