[ovs-dev] [PATCH 4/4] python: Style cleanup.

Ben Pfaff blp at nicira.com
Mon Sep 26 16:39:08 UTC 2011


On Sat, Sep 24, 2011 at 04:42:02PM -0700, Ethan Jackson wrote:
> This patch does minor style cleanups to the code in the python and
> tests directory.  There's other code floating around that could use
> similar treatment, but updating it is not convenient at the moment.

It seems OK to me.

I noticed one more bug to fix while reviewing this patch, would you
mind folding it into the series somewhere?

diff --git a/python/ovs/json.py b/python/ovs/json.py
index 2a3fd0d..721ffb6 100644
--- a/python/ovs/json.py
+++ b/python/ovs/json.py
@@ -249,7 +249,7 @@ class Parser(object):
                 self.__parser_input(0)
                 return
             elif significand <= 2**63:
-                while pow10 > 0 and significand <= 2*63:
+                while pow10 > 0 and significand <= 2**63:
                     significand *= 10
                     pow10 -= 1
                 while pow10 < 0 and significand % 10 == 0:



More information about the dev mailing list