[ovs-dev] [optimize 02/13] ofproto-dpif: Revalidate tagged packets, too, in facet_lookup_valid().

Ben Pfaff blp at nicira.com
Tue Sep 27 23:26:57 UTC 2011


I don't see a reason that we should only revalidate facets if we're
revalidating every facet.
---
 ofproto/ofproto-dpif.c |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)

diff --git a/ofproto/ofproto-dpif.c b/ofproto/ofproto-dpif.c
index f9c133e..8f3e900 100644
--- a/ofproto/ofproto-dpif.c
+++ b/ofproto/ofproto-dpif.c
@@ -2508,7 +2508,8 @@ facet_lookup_valid(struct ofproto_dpif *ofproto, const struct flow *flow)
     /* The facet we found might not be valid, since we could be in need of
      * revalidation.  If it is not valid, don't return it. */
     if (facet
-        && ofproto->need_revalidate
+        && (ofproto->need_revalidate
+            || tag_set_intersects(&ofproto->revalidate_set, facet->tags))
         && !facet_revalidate(ofproto, facet)) {
         COVERAGE_INC(facet_invalidated);
         return NULL;
-- 
1.7.4.4




More information about the dev mailing list