[ovs-dev] [PATCH] bridge: Clear out all Interface fields when an interface cannot be created.
Ben Pfaff
blp at nicira.com
Thu Sep 29 17:08:49 UTC 2011
Thanks. I tested this (in the process finding the use-after-free
problem that I just sent out a fix for) and pushed the fix.
On Wed, Sep 28, 2011 at 11:39:57AM -0700, Ethan Jackson wrote:
> Looks good.
>
> Ethan
>
> On Wed, Sep 28, 2011 at 09:37, Ben Pfaff <blp at nicira.com> wrote:
> > When an Interface record is invalid (for example, when the interface that
> > it specifies does not exist and cannot be created), ovs-vswitchd would
> > leave any pre-existing data in its columns, except that it would set the
> > ofport column to -1 to indicate the error. ?This was sometimes confusing
> > because, for example, the lacp_current field could still be set to "true"
> > if LACP has previously been active and up-to-date.
> >
> > This commit changes ovs-vswitchd to reset all such data to its default
> > values when an interface is invalid.
> >
> > Bug #7450.
> > Reported-by: Duffie Cooley <dcooley at nicira.com>
> > Bug #7491.
> > Reported-by: Ethan Jackson <ethan at nicira.com>
> > Release Notes #7500.
> > Reported-by: Keith Amidon <keith at nicira.com>
More information about the dev
mailing list