[ovs-dev] [appctl 3/7] lacp: Add "lacp/list" command to ovs-appctl.

[Ben Pfaff]

On Thu, Sep 29, 2011 at 03:34:39PM -0700, Justin Pettit wrote:
> diff --git a/NEWS b/NEWS
> index 99380cf..f23e7c7 100644
> --- a/NEWS
> +++ b/NEWS
> @@ -7,6 +7,7 @@ Post-v1.2.0
>      - ovs-appctl:
>        - New "version" command to determine version of running daemon
>        - New "cfm/list" command to print interfaces configured with CFM
> +      - New "lacp/list" command to print ports configured with LACP

Let's try to end all the items with '.'


> @@ -187,6 +189,7 @@ parse_lacp_packet(const struct ofpbuf *b)
>  void
>  lacp_init(void)
>  {
> +    unixctl_command_register("lacp/list", "port", lacp_unixctl_list, NULL);

I don't think that the command takes a parameter so s/"port"//.

I wonder whether this and cfm/list make all that much sense.  Can't we
find this stuff out from the database?  ovs-appctl is usually for
stuff we haven't figured out how to do correctly otherwise.

The implementation looks fine, though.