[ovs-dev] [layering 2/3] ofproto: Fix layer violation in in-band control.

Jesse Gross jesse at nicira.com
Fri Sep 30 01:55:23 UTC 2011


On Thu, Sep 29, 2011 at 3:40 PM, Ben Pfaff <blp at nicira.com> wrote:
> ofproto/in-band.[ch] is supposed to be a fairly high-level interface.  It
> has no business poking around ODP actions, and yet in_band_rule_check() did
> just that.  This commit fixes the problem by making the caller do the work
> related to actions.

This still seems like a layer violation to me because
in_band_rule_check() is making determinations based on what our kernel
module is able to match on.  Isn't this logically a component of
ofproto-dpif?



More information about the dev mailing list