[ovs-dev] [PATCH] Added handling of previously ignored cfm faults.

Ethan Jackson ethan at nicira.com
Thu Apr 5 23:00:20 UTC 2012


> -            rmp->recv = true;
> -            if (!fault) {
> +            if (!cfm_fault && !ccm_rdi) {
>                 rmp->num_health_ccm++;
>             }
> +            if (!cfm_fault) {
> +                rmp->recv = true;
> +            }
> +            cfm->recv_fault |= cfm_fault;

I have only one additional comment.  I think I was a bit wishy washy
on this so sorry if I said something else earlier.  It seems to me
that we want to increment num_health_ccm whenever rmp->recv is true,
and not otherwise.  That's conceptually simple, if we receive a
packet, it counts for both cfm_health and cfm_fault calculation.
Therfore I think we can collapse these two if blocks into one.

Ethan



More information about the dev mailing list