[ovs-dev] [PATCH] ovs-save: Add "dev" keyword before interface names in the ip commands

Ben Pfaff blp at nicira.com
Mon Apr 16 16:32:53 UTC 2012


On Mon, Apr 16, 2012 at 01:10:47PM +0000, Kyle Mestery (kmestery) wrote:
> This looks great, but a quick grep found the "ip link" command used
> in this script as well:
> 
> xenserver/etc_xensource_scripts_vif
> 
> Since that script is for xenserver, I assume the same issue found
> below won't exist there?

Good catch.

XenServer names its bridges and devices systematically.  None of the
names that it uses can match a prefix of "broadcast".

I'd be inclined to apply a similar fix there nevertheless, except that
this script is owned by Citrix upstream.  We could report it to the
Citrix guys, but they'd be well within their rights to just say, "So?
Won't happen on XenServer," so I'm kind of inclined not to bother.



More information about the dev mailing list