[ovs-dev] [PATCH 2/2] rconn: Simplify rconn_send() semantics.
Ben Pfaff
blp at nicira.com
Thu Apr 26 21:24:25 UTC 2012
On Wed, Apr 25, 2012 at 09:16:33PM -0700, Ethan Jackson wrote:
> Before this patch, rconn_send() would delete 'b' on success, and
> not on error. This is confusing and error-prone. This patch
> causes rconn_send() to always delete 'b'.
>
> Signed-off-by: Ethan Jackson <ethan at nicira.com>
> +/* Sends 'b' on 'rc'. Returns 0 if successful, or ENOTCONN if 'rc' is not
> + * currently connected. In either case, 'b' is deleted.
I think it would be better to say that ownership of 'b' gets
transferred to 'rc'; it won't necessarily be deleted immediately.
Either way this is an improvement, thank you.
More information about the dev
mailing list