[ovs-dev] [PATCH] cfm: Avoid constructing log message that will be dropped by rate-limiting.

[Ethan Jackson]

Looks good, thanks.

Ethan

On Mon, Apr 30, 2012 at 13:02, Ben Pfaff <blp at nicira.com> wrote:
> Signed-off-by: Ben Pfaff <blp at nicira.com>
> ---
>  lib/cfm.c |    6 +++---
>  1 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/lib/cfm.c b/lib/cfm.c
> index 66bca75..38de68f 100644
> --- a/lib/cfm.c
> +++ b/lib/cfm.c
> @@ -394,12 +394,12 @@ cfm_run(struct cfm *cfm)
>             cfm->fault |= CFM_FAULT_RECV;
>         }
>
> -        if (old_cfm_fault != cfm->fault) {
> +        if (old_cfm_fault != cfm->fault && !VLOG_DROP_INFO(&rl)) {
>             struct ds ds = DS_EMPTY_INITIALIZER;
>
>             ds_put_cfm_fault(&ds, old_cfm_fault, cfm->fault);
> -            VLOG_INFO_RL(&rl, "%s: CFM fault status changed:%s", cfm->name,
> -                         ds_cstr_ro(&ds));
> +            VLOG_INFO("%s: CFM fault status changed:%s", cfm->name,
> +                      ds_cstr_ro(&ds));
>             ds_destroy(&ds);
>         }
>
> --
> 1.7.2.5
>
> _______________________________________________
> dev mailing list
> dev at openvswitch.org
> http://openvswitch.org/mailman/listinfo/dev