[ovs-dev] [PATCH] bridge: New appctl command iface/set-admin-state.

Ben Pfaff blp at nicira.com
Fri Aug 10 16:13:14 UTC 2012


On Thu, Aug 09, 2012 at 06:21:43PM -0700, Ethan Jackson wrote:
> There's currently no way to set the admin state on dummy netdevs.
> This patch provides a mechanism to do so that generalizes to all
> netdevs cleanly.
> 
> Signed-off-by: Ethan Jackson <ethan at nicira.com>

I have mixed feelings about this.  From a broad perspective it seems
like an odd feature, since I can normally use (and I'm accustomed to
using) something platform-specific like 'ifconfig' or 'ip' to bring an
interface up or down.  But I see why you'd like to make it
general-purpose.  Still, I'm not sure how we explain it to end users,
because for it to make any sense, I think that we have to bring in
"dummy" netdevs, which are a feature that they can't use and don't
have a use for anyway.

I kind of feel like it's a wart that should be confined to
netdev-dummy.

s/ , /, / here, twice:
> +    if (!strcasecmp(argv[argc - 1] , "up")) {
> +        up = true;
> +    } else if ( !strcasecmp(argv[argc - 1] , "down")) {
> +        up = false;



More information about the dev mailing list