[ovs-dev] [PATCH] bridge: Write certain statistics to the database instantly.

Ben Pfaff blp at nicira.com
Wed Aug 15 21:32:49 UTC 2012


On Tue, Aug 14, 2012 at 02:27:37PM -0700, Ethan Jackson wrote:
> Traditionally the bridge has written interface and port statistics
> to the database in a rate limited fashion.  This makes a lot of
> sense for statistics which are either constantly changing, or are
> expensive to collect.  However, some statistics were rate limited
> which have neither of these properties.  Furthermore some of these
> statistics (most notably carrier) could be very useful to a
> controller if updated promptly.
> 
> Signed-off-by: Ethan Jackson <ethan at nicira.com>

The new code has
        }
        else {
in place of 
        } else {
in one spot.

Otherwise I see nothing to complain about, at least short of finding
out that this is a performance problem in the real world.

Thanks,

Ben.



More information about the dev mailing list