[ovs-dev] [PATCH] Add Nicira vendor extension action NXAST_DEC_TTL_CNT_IDS.

[Ben Pfaff]

Thanks.

On Thu, Aug 16, 2012 at 02:27:23PM -0700, Mehak Mahajan wrote:
> Thanks Ben for your help/reviews.
> 
> I have added this test.
> 
> +# actions=dec_ttl(32768,12345,90,765,1024)
> +ffff 0020 00002320 0015 000500000000 80003039005A02fd 0400000000000000
> +
> 
> I will do a quick retest and will push the patch shortly.
> 
> thanx!
> mehak
> 
> On Thu, Aug 16, 2012 at 1:41 PM, Ben Pfaff <blp at nicira.com> wrote:
> 
> > On Thu, Aug 16, 2012 at 01:36:47PM -0700, Mehak Mahajan wrote:
> > > Currently, if a controller having a nonzero id registers to get a
> > > OFPR_INVALID_TTL async message, it will not receive it.  This is because
> > > compose_dec_ttl() only sent the invalid ttl packets to the default
> > controller
> > > id.  NXAST_DEC_TTL_CNT_IDS is a new action that accepts a list of
> > controller
> > > ids, each separated by `,', to which the OFPR_INVALID_TTL packets must
> > be sent.
> > > The earlier requirement of the controller having to explicitly register
> > to
> > > receive these asynchronous messages is retained.
> > > The syntax of this action is:
> > >     dec_ttl(id1,id2)
> > > where id1, id2 are valid controller ids.
> > >
> > > Signed-off-by: Mehak Mahajan <mmahajan at nicira.com>
> >
> > It would be nice to add a test that uses more than one controller id.
> >
> > Otherwise, thanks, this looks good to me.
> >