[ovs-dev] [PATCH 1/4] tests: Factor "seq" shell function out into common infrastructure.

Ethan Jackson ethan at nicira.com
Thu Aug 16 22:44:51 UTC 2012


Looks good, thanks.

On Fri, Aug 10, 2012 at 3:25 PM, Ben Pfaff <blp at nicira.com> wrote:
> An upcoming patch will introduce a second user.
>
> Signed-off-by: Ben Pfaff <blp at nicira.com>
> ---
>  tests/ovs-ofctl.at |    8 --------
>  tests/testsuite.at |    8 ++++++++
>  2 files changed, 8 insertions(+), 8 deletions(-)
>
> diff --git a/tests/ovs-ofctl.at b/tests/ovs-ofctl.at
> index f35ac41..2a298c5 100644
> --- a/tests/ovs-ofctl.at
> +++ b/tests/ovs-ofctl.at
> @@ -1934,14 +1934,6 @@ AT_CLEANUP
>  AT_SETUP([ovs-ofctl diff-flows])
>  OVS_VSWITCHD_START
>
> -# Prints the integers from $1 to $2, increasing by $3 (default 1) on stdout.
> -seq () {
> -    while test $1 -le $2; do
> -        echo $1
> -        set `expr $1 + ${3-1}` $2 $3
> -    done
> -}
> -
>  # Add tons of flows to br0.
>  for i in `seq 0 1023`; do echo "dl_vlan=$i,actions=drop"; done > add-flows.txt
>  AT_CHECK([ovs-ofctl add-flows br0 add-flows.txt])
> diff --git a/tests/testsuite.at b/tests/testsuite.at
> index 3ec28d6..e8f7498 100644
> --- a/tests/testsuite.at
> +++ b/tests/testsuite.at
> @@ -33,6 +33,14 @@ ovs_wait () {
>      done
>      exit 1
>  }
> +
> +# Prints the integers from $1 to $2, increasing by $3 (default 1) on stdout.
> +seq () {
> +    while test $1 -le $2; do
> +        echo $1
> +        set `expr $1 + ${3-1}` $2 $3
> +    done
> +}
>  ]
>  m4_divert_pop([PREPARE_TESTS])
>
> --
> 1.7.2.5
>
> _______________________________________________
> dev mailing list
> dev at openvswitch.org
> http://openvswitch.org/mailman/listinfo/dev



More information about the dev mailing list