[ovs-dev] [PATCH] ofp-print: Fix memory leak printing flow stats replies.

Ben Pfaff blp at nicira.com
Fri Aug 17 22:15:29 UTC 2012


Thanks for the review.  I pushed this to master and soon to branch-1.8.

On Fri, Aug 17, 2012 at 02:48:19PM -0700, Mehak Mahajan wrote:
> Looks good.
> 
> thanx!
> mehak
> 
> On Fri, Aug 17, 2012 at 1:59 PM, Ben Pfaff <blp at nicira.com> wrote:
> 
> > Found by valgrind.
> >
> > Signed-off-by: Ben Pfaff <blp at nicira.com>
> > ---
> >  lib/ofp-print.c |    1 +
> >  1 files changed, 1 insertions(+), 0 deletions(-)
> >
> > diff --git a/lib/ofp-print.c b/lib/ofp-print.c
> > index 3f5b6be..99e6456 100644
> > --- a/lib/ofp-print.c
> > +++ b/lib/ofp-print.c
> > @@ -1044,6 +1044,7 @@ ofp_print_flow_stats_reply(struct ds *string, const
> > struct ofp_header *oh)
> >          ds_put_char(string, '\n');
> >          ofp_print_flow_stats(string, &fs);
> >       }
> > +    ofpbuf_uninit(&ofpacts);
> >  }
> >
> >  static void
> > --
> > 1.7.2.5
> >
> > _______________________________________________
> > dev mailing list
> > dev at openvswitch.org
> > http://openvswitch.org/mailman/listinfo/dev
> >



More information about the dev mailing list