[ovs-dev] [deprecation 2/2] nicira-ext: Deprecate the autopath action.

Ben Pfaff blp at nicira.com
Sat Aug 18 02:43:21 UTC 2012


On Fri, Aug 17, 2012 at 07:18:41PM -0700, Ethan Jackson wrote:
> diff --git a/lib/autopath.c b/lib/autopath.c
> index 93fedd1..61c5026 100644
> --- a/lib/autopath.c
> +++ b/lib/autopath.c
> @@ -32,6 +32,8 @@
>  
>  VLOG_DEFINE_THIS_MODULE(autopath);
>  
> +static bool warned = false;
> +
>  void
>  autopath_parse(struct ofpact_autopath *ap, const char *s_)
>  {
> @@ -89,6 +91,12 @@ autopath_from_openflow(const struct nx_action_autopath *nap,
>  enum ofperr
>  autopath_check(const struct ofpact_autopath *autopath, const struct flow *flow)
>  {
> +    if (!warned) {
> +        warned = true;
> +        VLOG_WARN("The autopath action is deprecated and may be removed in"
> +                  " February 2012.  Please email dev at openvswitch.org with"
> +                  " concerns.");
> +    }

s/2012/2013/

I suggest VLOG_WARN_ONCE instead of a separate 'warned' variable.



More information about the dev mailing list