[ovs-dev] [PATCH 12/27] ofp-util: Allow decoding of Open Flow 1.1 & 1.2 Port Status Request Messages

Simon Horman horms at verge.net.au
Thu Aug 30 01:08:25 UTC 2012


On Wed, Aug 29, 2012 at 11:11:14AM -0700, Ben Pfaff wrote:
> On Tue, Aug 21, 2012 at 01:55:44PM +0900, Simon Horman wrote:
> > Signed-off-by: Simon Horman <horms at verge.net.au>
> 
> I think it would be better to add an ofputil.c function to decode a port
> stats request message into an abstract format, rather than to inline
> that decoding into ofproto.c.  (The commit message title "ofp-util: ..."
> implies that that was what you had in mind, but it is not what the patch
> does.)

I wrote this a little while ago, so I'm not quite sure what I had in mind at
the time. But your suggestion sounds good, I'll try and rearrange things
accordingly.



More information about the dev mailing list