[ovs-dev] [PATCH 1/5] lib/ofp-util: preparation for OF12 of ofp-util

Ben Pfaff blp at nicira.com
Thu Aug 30 18:32:06 UTC 2012


On Thu, Aug 30, 2012 at 10:40:23AM +0900, Simon Horman wrote:
> From: Isaku Yamahata <yamahata at valinux.co.jp>
> 
> Add necessary macros to ofp-util for OF12 support.
> This is just a place holder.
> 
> Signed-off-by: Isaku Yamahata <yamahata at valinux.co.jp>
> Signed-off-by: Simon Horman <horms at verge.net.au>

I think that the new NOT_REACHED() in parse_named_action() can actually
be hit if the user attempts to use this action.  I'd rather avoid adding
that kind of breakage, even temporarily.  I can see a few ways to avoid
it.  The most obvious ones are to leave OFPAT12_SET_FIELD commented out
with the rest of the new actions in ofp-util.def or to give NULL as its
name in ofp-util.def.

Thanks,

Ben.



More information about the dev mailing list