[ovs-dev] [PATCH] vswitchd: log skb_mark and skb_priority

[Jesse Gross]

On Fri, Nov 30, 2012 at 4:13 PM, Ben Pfaff <blp at nicira.com> wrote:
> On Fri, Nov 30, 2012 at 04:07:29PM -0800, Ansis Atteka wrote:
>> This patch adds logging support for skb_mark and skb_priority.
>>
>> Signed-off-by: Ansis Atteka
>
> skb_priority has two 16-bit subfields, at least with the qdiscs that
> I'm familiar with, so it's easier to read when it's printed in
> hexadecimal.  This means that I'd change "%"PRIu32 to "%#"PRIx32 and
> MFS_DECIMAL to MFS_HEXADECIMAL for this field.

If we do that (which sounds fine), we probably should also update
odp-util.c to print priority in hex.  It might not be a bad idea to
make mark hex as well.