[ovs-dev] [PATCHv2 1/2] ovs-vsctl: Add "--real" and "--fake" options to "list-br".

Ben Pfaff blp at nicira.com
Sat Dec 1 19:25:17 UTC 2012


On Sat, Dec 01, 2012 at 11:20:35AM -0800, Justin Pettit wrote:
> By default, "ovs-vsctl list-br" returns all bridges, real or fake.  This
> commit adds "--real" and "--fake" options that limit the output to only
> bridges of that type.  This will be useful in a future commit that needs
> to perform actions only on bridges of a particular type.
> 
> Signed-off-by: Justin Pettit <jpettit at nicira.com>

Ideally we'd add one or two usages to tests/ovs-vsctl.at.

One could write this:
        if ((br->parent && fake) || (!br->parent && real)) { 
as:
        if (br->parent ? fake : real) { 
Personally I think that's more straightforward, but you may not agree.
Certainly, I understand both forms.

Thanks,

Ben.



More information about the dev mailing list