[ovs-dev] [PATCHv2 1/2] ovs-vsctl: Add "--real" and "--fake" options to "list-br".

Ben Pfaff blp at nicira.com
Sun Dec 2 00:00:18 UTC 2012


On Sat, Dec 01, 2012 at 03:54:58PM -0800, Justin Pettit wrote:
> On Sat, Dec 1, 2012 at 11:25 AM, Ben Pfaff <blp at nicira.com> wrote:
>
> > Ideally we'd add one or two usages to tests/ovs-vsctl.at.
>
> Okay.  How about the following incremental?

Looks good, thanks.

> > One could write this:
> >         if ((br->parent && fake) || (!br->parent && real)) {
> > as:
> >         if (br->parent ? fake : real) {
> > Personally I think that's more straightforward, but you may not agree.
> > Certainly, I understand both forms.
> >
>
> Yeah, I think that's cleaner.  I went ahead and changed it to that.

Thanks.



More information about the dev mailing list