[ovs-dev] [PATCH] Discourage use of unencodable error codes, add a generic OFPERR_NX__UNKNOWN_ERROR code.

Jarno Rajahalme jarno.rajahalme at nsn.com
Tue Dec 4 13:26:25 UTC 2012


On Dec 3, 2012, at 21:21 , ext Ben Pfaff wrote:

> On Sat, Dec 01, 2012 at 09:55:58AM -0800, Ben Pfaff wrote:
>> On Fri, Nov 30, 2012 at 02:22:00PM +0200, Jarno Rajahalme wrote:
>>>    Removed error category types (OFPERR_OFPET_*) from enum ofperr to make it harder for contributors to use
>>>    unencodable error codes. Removed corresponding functions ofperr_is_category() and ofperr_decode_type().
>>>    Added OFPERR_NX__UNKNOWN_ERROR (NX1.0+(0xfffe,256)), which is now encoded if the error code given to
>>>    ofperr_encode_msg__() cannot be encoded with the given ofp_version. The rationale is that the corresponding
>>>    OF transaction has failed, and the controller must know this, so sending no error message is not an option.
>>>    Changed ofperr_encode_msg__() logging from WARN to ERR, as using unencodable error codes for the underlying
>>>    openflow version is an error.
>>>    Added OFPERR_NXBRC_FM_BAD_EVENT to avoid using an unencodable error code in ofputil_decode_flow_update().
>>>    Replaced unencodable error codes in ofp-actions.c with encodable ones.
>> 
>> This mostly looks good.  I spent some time Friday breaking it up into
>> smaller commits and fixing a few existing bugs that I noticed while
>> reviewing it.  I'm not quite done; I'll probably post the new series on
>> Monday.
> 
> I posted it starting at:
>        http://openvswitch.org/pipermail/dev/2012-December/023543.html
> 
> Jarno, will you please review it?
> 

Reviewed, looks good and seems to work as well,

Thanks,

  Jarno




More information about the dev mailing list