[ovs-dev] [PATCH] INSTALL.Debian: New instructions for installing on Debian.

[Kyle Mestery (kmestery)]

On Dec 4, 2012, at 9:40 AM, Ben Pfaff <blp at nicira.com>
 wrote:
> On Tue, Dec 04, 2012 at 02:19:10PM +0000, Kyle Mestery (kmestery) wrote:
>> 
>> On Dec 4, 2012, at 12:02 AM, Ben Pfaff <blp at nicira.com> wrote:
>> 
>>> Signed-off-by: Ben Pfaff <blp at nicira.com>
>>> ---
>>> INSTALL        |    7 +---
>>> INSTALL.Debian |  125 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++
>>> Makefile.am    |    1 +
>>> README         |   31 ++++++++------
>>> 4 files changed, 146 insertions(+), 18 deletions(-)
>>> create mode 100644 INSTALL.Debian
>>> 
>>> diff --git a/INSTALL b/INSTALL
>>> index 4d94c52..dac3ad9 100644
>>> --- a/INSTALL
>>> +++ b/INSTALL
>>> @@ -3,11 +3,8 @@
>>> 
>>> This document describes how to build and install Open vSwitch on a
>>> generic Linux or FreeBSD host.  If you want to install Open vSwitch on
>>> -a Citrix XenServer, see INSTALL.XenServer instead.
>>> -
>>> -This version of Open vSwitch may be built manually with "configure"
>>> -and "make", as described below.  You may also build Debian packages by
>>> -running "dpkg-buildpackage".
>>> +a Citrix XenServer, see INSTALL.XenServer instead.  If you want to
>>> +build Debian packages for Open vSwitch, see INSTALL.Debian.
>>> 
>> Since you're editing the beginning of INSTALL and you've added a reference to
>> INSTALL.Debian, do you also want to reword this to include INSTALL.RHEL and
>> INSTALL.Fedora? Maybe something like this:
>> 
>> This document describes how to build and install Open vSwitch on a generic Linux
>> or FreeBSD host. For specifics around installation on a specific platform, please see
>> one of these files:
>> 	- INSTALL.Debian
>> 	- INSTALL.Fedora
>> 	- INSTALL.RHEL
>> 	- INSTALL.XenServer
> 
> That's better, thanks, I used that wording.
> 
>> I think this also highlights it would be good to have a
>> INSTALL.FreeBSD here as well.
> 
> INSTALL is supposed to cover both Linux and FreeBSD (and, with luck, any
> other software switch system for which support is contributed).  If
> there is any FreeBSD specific packaging or information, etc., then I'd
> be happy to put it in a new INSTALL.FreeBSD.
> 
>>> -To use Open vSwitch as a drop-in replacement for the Linux bridge,
>>> -read INSTALL.bridge.
>>> +    - ...on a Red Hat Enterprise Linux host via RPMs, read
>>> +      INSTALL.RHEL.
>>> 
>>> -To build RPMs for installing Open vSwitch on a Citrix XenServer host
>>> -or resource pool, read INSTALL.XenServer.
>>> +To use Open vSwitch...
>>> 
>>> -To build RPMs for installing Open vSwitch on a Red Hat Enterprise
>>> -Linux host, read INSTALL.RHEL.
>>> +    - ...with KVM on Linux, read INSTALL, read INSTALL.KVM.
>>> 
>> Perhaps we also want to mention INSTALL.Fedora here as well?
> 
> I changed it to the form you suggested for the top of INSTALL.Debian.
> 
> Thanks, I'll apply this soon.

Awesome, thanks!

Acked-by: Kyle Mestery <kmestery at cisco.com>