[ovs-dev] [PATCH] ofproto: Report correct error for emergency flow with timeout.

Ben Pfaff blp at nicira.com
Tue Dec 4 20:52:02 UTC 2012


On Thu, Nov 01, 2012 at 12:22:41AM -0700, Ben Pfaff wrote:
> The OpenFlow 1.0 specification says:
> 
>     Emergency flow mod messages must have timeout values set to zero.
>     Otherwise, the switch must refuse the addition and respond with an
>     ofp_error_msg with OFPET_FLOW_MOD_FAILED type and
>     OFPFMFC_BAD_EMERG_TIMEOUT code.
> 
> but Open vSwitch reported OFPFMFC_TABLE_FULL in this case.  This commit
> fixes the problem.
> 
> Fixes detailed_contr_sw_messages.EmerFlowTimeout failure in OFTest.
> 
> Signed-off-by: Ben Pfaff <blp at nicira.com>

This is trivial and fixes a conformance bug, so I'd like to get it
reviewed.



More information about the dev mailing list