[ovs-dev] [PATCH] ovs-vsctl: Allow command-specific options to mingle with global options.

Kyle Mestery (kmestery) kmestery at cisco.com
Fri Dec 7 22:05:50 UTC 2012


On Dec 4, 2012, at 2:51 PM, Ben Pfaff <blp at nicira.com> wrote:
> On Mon, Oct 29, 2012 at 09:34:37AM -0700, Ben Pfaff wrote:
>> Until now, a command like "ovs-vsctl --may-exist add-br br0" yielded a
>> confusing error message.  Users had to realize that the correct form was
>> "ovs-vsctl -- --may-exist add-br br0", but instead they often reported a
>> bug or gave up in frustration.  Even though the behavior was documented, it
>> was counterintuitive.
>> 
>> This commit allows command-specific options to be mixed with global
>> options, making both forms of the command listed above equally acceptable.
>> 
>> CC: 691508 at bugs.debian.org
>> Reported-by: Adam Heath <doogie at brainfood.com>
>> Signed-off-by: Ben Pfaff <blp at nicira.com>
> 
> This has confused many users--including me--over the years, so I'd
> like to get it reviewed.

I agree, this will be super handy to have in (even I've been confused by this in the past).

Acked-by: Kyle Mestery <kmestery at cisco.com>

> _______________________________________________
> dev mailing list
> dev at openvswitch.org
> http://openvswitch.org/mailman/listinfo/dev





More information about the dev mailing list