[ovs-dev] [PATCH] v3 openvswitch: Remove Linux bridge compatibility.

Jesse Gross jesse at nicira.com
Thu Dec 13 19:42:57 UTC 2012


On Thu, Dec 13, 2012 at 6:59 AM, Pravin B Shelar <pshelar at nicira.com> wrote:
> diff --git a/NEWS b/NEWS
> index 2255805..57e29e4 100644
> --- a/NEWS
> +++ b/NEWS
> @@ -5,7 +5,7 @@ post-v1.9.0
>        http://tools.ietf.org/html/draft-mahalingam-dutt-dcops-vxlan-02).
>      - New "vlog/disable-rate-limit" and "vlog/enable-rate-limit" commands
>        available through ovs-appctl allow control over logging rate limits.
> -
> +    - Bridge compatibility is removed.

Can you keep the double blank line between entries?

> diff --git a/datapath/vport.h b/datapath/vport.h
> index 1a2e9ef..12cad55 100644
> --- a/datapath/vport.h
> +++ b/datapath/vport.h
> @@ -158,7 +156,6 @@ struct vport_parms {
>   * @get_name: Get the device's name.
>   * @get_addr: Get the device's MAC address.
>   * @get_config: Get the device's configuration.
> - * @get_kobj: Get the kobj associated with the device (may return null).
>   * @get_dev_flags: Get the device's flags.
>   * @is_running: Checks whether the device is running.
>   * @get_operstate: Get the device's operating state.

There are still a few vport ops that are now unused and can be removed:
 * @get_dev_flags: Get the device's flags.
 * @is_running: Checks whether the device is running.
 * @get_operstate: Get the device's operating state.
 * @get_mtu: Get the device's MTU.  May be %NULL if the device does not have an
 * MTU (as e.g. some tunnels do not).  Must be implemented if @get_ifindex is
 * implemented.

In addition, can you make a separate patch for branch-1.9 noting that
brcompat will be removed in the next release and warning if someone
uses it?



More information about the dev mailing list