[ovs-dev] [PATCH] meta-flow: Fix and simplify mf_get_mask().

Ben Pfaff blp at nicira.com
Tue Dec 18 18:16:13 UTC 2012


On Tue, Dec 18, 2012 at 10:02:27AM -0800, Jesse Gross wrote:
> On Tue, Dec 18, 2012 at 9:45 AM, Ben Pfaff <blp at nicira.com> wrote:
> > This function can be implemented as a trivial wrapper around
> > mf_get_value(), which I hadn't noticed before, so it's better to do it
> > that way.  Also, examining the code that is removed, it had some bugs in
> > it (for example, all MFF_TUN_* fields were treated as if they were
> > MFF_TUN_ID) which mf_get_value() does not have, so this fixes bugs too.
> >
> > Signed-off-by: Ben Pfaff <blp at nicira.com>
> 
> This seems like an obvious improvement.

Thanks, I pushed it to master and branch-1.9.



More information about the dev mailing list