[ovs-dev] [leaks 2/4] ofproto-dpif: Fix memory leak in type_run().
Ben Pfaff
blp at nicira.com
Tue Dec 18 21:51:03 UTC 2012
The dpif_port_destroy() call was in the dpif_port_query_by_name() error
path, when there's nothing to destroy, rather than in the "success" path,
where there is data to destroy.
Signed-off-by: Ben Pfaff <blp at nicira.com>
---
ofproto/ofproto-dpif.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/ofproto/ofproto-dpif.c b/ofproto/ofproto-dpif.c
index 95fd54e..b78d6cf 100644
--- a/ofproto/ofproto-dpif.c
+++ b/ofproto/ofproto-dpif.c
@@ -850,12 +850,12 @@ type_run(const char *type)
sset_add(&ofproto->port_poll_set, devname);
ofproto->port_poll_errno = 0;
}
- dpif_port_destroy(&port);
} else if (!ofproto) {
/* The port was added, but we don't know with which
* ofproto we should associate it. Delete it. */
dpif_port_del(backer->dpif, port.port_no);
}
+ dpif_port_destroy(&port);
free(devname);
}
--
1.7.2.5
More information about the dev
mailing list