[ovs-dev] [PATCH 1/6] ofproto-dpif: New function ofproto_receive().

Ethan Jackson ethan at nicira.com
Thu Dec 27 19:37:31 UTC 2012


> Why shouldn't we give up in trace, as we do in the packet receive
> path, if the port can't be found?  "trace" is supposed to match the
> packet receive path (otherwise it isn't as useful).  I guess the
> reason is that we don't have to, since the user specified the ofproto
> name, but I think that we should anyway.
>

There seems to be some contention on this point.  Currently, the unit tests
rely on this behavior.  Specifically, you can do a trace without specifying
an in_port and it will implicitly use OFPP_NONE.  In previous rounds of
review, I had suggested that we remove this option, and require a valid
in_port to trace.  Jesse suggested that this feature is important.  I
really don't care either way.  Could you two please make a decision on the
point?

Ethan
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openvswitch.org/pipermail/ovs-dev/attachments/20121227/546f895c/attachment-0003.html>


More information about the dev mailing list