[ovs-dev] [PATCH 2/2] ofproto-dpif: Initialize tunnel metadata in both 'flow' and 'base_flow'.

Jesse Gross jesse at nicira.com
Mon Dec 31 20:59:58 UTC 2012


On Mon, Dec 31, 2012 at 12:58 PM, Ben Pfaff <blp at nicira.com> wrote:
> On Mon, Dec 31, 2012 at 12:48:04PM -0800, Jesse Gross wrote:
>> The datapath doesn't carry over tunnel metadata between input and
>> output because such an operation doesn't generally make sense.  In
>> order to keep the flow information in sync, userspace needs to do
>> this as well.  However, userspace was clearing out only the base
>> flow, which means that it later generated an action with the original
>> tunnel metadata.  If a packet is both being sent and received on a
>> tunnel then this will cause the output tunnel's configuration to be
>> overriden with incorrect information.  This was recently exposed
>> when the ability to interpret tunnel metadata was added to userspace.
>>
>> Reported-by: Anand Krishnamurthy <krishnamurt4 at wisc.edu>
>> Reported-by: Saul St. John <sstjohn at cs.wisc.edu>
>> Signed-off-by: Jesse Gross <jesse at nicira.com>
>
> Looks good to me, thanks.

Thanks, I pushed both of these patches to master and the first one to
branch-1.9.



More information about the dev mailing list