[ovs-dev] [PATCH 1/2] xenserver: Always update the bridge ID in ovs-xapi-sync.

Justin Pettit jpettit at nicira.com
Thu Mar 1 03:59:54 UTC 2012


On Feb 29, 2012, at 7:53 PM, Ben Pfaff wrote:

> On Wed, Feb 29, 2012 at 07:49:32PM -0800, Ben Pfaff wrote:
>> On Wed, Feb 29, 2012 at 07:17:24PM -0800, Ethan Jackson wrote:
>>> In some cases we were seeing this column get stale.
>>> 
>>> Bug #9929.
>>> Signed-off-by: Ethan Jackson <ethan at nicira.com>
>> 
>> This seems fine as a fix for now, but I think that it causes
>> ovs-xapi-sync to fetch all of the network records from XAPI on every
>> iteration, so I think that we should consider caching the
>> xs-network-uuids to bridge-id mapping in the same way that we now cache
>> the iface-id mapping.
> 
> Also, Justin deserves credit in the change log for tracking this down.

And Ben deserves credit for the second one, which was completely non-obvious and was going to be horrendous to track down.  Thanks for turning around these patches so quickly, Ethan.

Group hug!

--Justin





More information about the dev mailing list