[ovs-dev] [PATCH v4] rhel: Enable DHCP in redhat network scripts.

[Ben Pfaff]

On Fri, Feb 03, 2012 at 04:30:36PM +0400, Alexey I. Froloff wrote:
> On Tue, Jan 31, 2012 at 01:53:49PM -0800, Gurucharan Shetty wrote:
> > +			case ${OVSDHCPINTERFACES} in
> > +				${OVSINTF#ifcfg-} | \
> > +				"${OVSINTF#ifcfg-},"* | \
> > +				*",${OVSINTF#ifcfg-}" | \
> > +				*",${OVSINTF#ifcfg-},"*)
> As an Old Fart ;-) I'd want to say, that this could be written
> as:
> 
> case ",${OVSDHCPINTERFACES}," in
>   *",${OVSINTF#ifcfg-},"*)

I knew that I was missing a trick here.  (And it's a trick I've
actually used before!)  Thanks, I sent out a patch.

> And instead of comma-separated list OVSDHCPINTERFACES could be
> space separated list (as in $BOND_IFACES), and instead of
> OVSINTF=${CONFIG} we could use OVSINTF=${DEVICE}, this way we
> don't need to strip the "ifcfg-" prefix.

Guru, should we make that change?  I suggested a comma originally
because I though it would be easier to write the shell fragments (no
need for quotes) but I didn't realize that there was precedent for
spaces.

> I was also thinking about my proposal to specify all Port
> configuration in Bridge config file.  Advantage of this method is
> when you ifup a Bridge, all Ports will be automatically added to
> this Bridge.

My understanding is that ordinary Linux bridges don't work that way
with the RHEL network scripts.  Is that correct?  I think that it is
a good idea for OVS and the Linux bridge to act the same way, to the
extent that it is possible, to avoid surprising administrators used to
the Linux bridge behavior under RHEL.

> Disadvantage is when you ifdown/ifup a Port, it
> will not be added back to Bridge.  This could be serious issue
> for, like, PPP-based devices.  Since current implementation
> satisfies everyone, let it be.

OK.