[ovs-dev] [PATCH] xenserver: Remove dead code from ovs-xapi-sync.
Ben Pfaff
blp at nicira.com
Mon Feb 6 18:23:06 UTC 2012
Thanks, I pushed this.
On Fri, Feb 03, 2012 at 03:44:07PM -0800, Ethan Jackson wrote:
> Looks good to me.
>
> Ethan
>
> On Fri, Feb 3, 2012 at 15:40, Ben Pfaff <blp at nicira.com> wrote:
>
> > Nothing actually uses call_vsctl(), so remove it and its dependencies.
> >
> > Signed-off-by: Ben Pfaff <blp at nicira.com>
> > ---
> > .../usr_share_openvswitch_scripts_ovs-xapi-sync | 10 ----------
> > 1 files changed, 0 insertions(+), 10 deletions(-)
> >
> > diff --git a/xenserver/usr_share_openvswitch_scripts_ovs-xapi-sync
> > b/xenserver/usr_share_openvswitch_scripts_ovs-xapi-sync
> > index 8392c61..b10df6b 100755
> > --- a/xenserver/usr_share_openvswitch_scripts_ovs-xapi-sync
> > +++ b/xenserver/usr_share_openvswitch_scripts_ovs-xapi-sync
> > @@ -25,7 +25,6 @@
> > import argparse
> > import os
> > import signal
> > -import subprocess
> > import sys
> > import time
> >
> > @@ -34,13 +33,11 @@ import XenAPI
> > import ovs.dirs
> > from ovs.db import error
> > from ovs.db import types
> > -import ovs.util
> > import ovs.daemon
> > import ovs.db.idl
> >
> > root_prefix = '' # Prefix for absolute file names, for
> > testing.
> > vlog = ovs.vlog.Vlog("ovs-xapi-sync")
> > -vsctl = "/usr/bin/ovs-vsctl"
> > session = None
> > force_run = False
> >
> > @@ -116,13 +113,6 @@ def get_iface_id(if_name, xs_vif_uuid):
> > return xs_vif_uuid
> >
> >
> > -def call_vsctl(args):
> > - cmd = [vsctl, "--timeout=30", "-vANY:console:off"] + args
> > - exitcode = subprocess.call(cmd)
> > - if exitcode != 0:
> > - vlog.warn("Couldn't call ovs-vsctl")
> > -
> > -
> > def set_or_delete(d, key, value):
> > if value is None:
> > if key in d:
> > --
> > 1.7.2.5
> >
> > _______________________________________________
> > dev mailing list
> > dev at openvswitch.org
> > http://openvswitch.org/mailman/listinfo/dev
> >
More information about the dev
mailing list