[ovs-dev] [time_left 3/3] Add information about time left before timeouts to flow dumps.
Ethan Jackson
ethan at nicira.com
Mon Feb 6 22:59:12 UTC 2012
In learning switch, should OFPUTIL_NXT_FLOW_AGE return an error as per the spec?
> + cookie=0x0, duration=2.88s, table=0, n_packets=1, n_bytes=60, idle_timeout=5,hard_timeout=10,idle_age=2,hard_age=7,priority=65535,tcp,in_port=3,vlan_tci=0x0000,dl_src=50:54:00:00:00:05,dl_dst=50:54:00:00:00:06,nw_src=192.168.0.1,nw_dst=192.168
This particular case looked very strange to me for a few seconds
because the hard_age is larger than the duration which shouldn't be
possible. Of course, this is only testing the parser, but perhaps it
makes sense to use a smaller value in the test just so it looks
normal.
Also in the unit tests you've added, you check that the duration,
idle_age, and hard_age are increasing. Does it make sense to also
check that at each step duration >= hard_age >= idle_age?
Looks good,
Ethan
More information about the dev
mailing list