[ovs-dev] [async-msgs 12/13] ofproto: Implement OpenFlow extension to allow control over async messages.

Ben Pfaff blp at nicira.com
Thu Feb 9 21:34:54 UTC 2012


On Thu, Feb 09, 2012 at 12:01:52PM -0800, Ethan Jackson wrote:
> The comment of the OAM_PACKET_IN definition has a redundant period.

Thanks, fixed.

> ofproto.at has a redundant newline at the end of the file.

Thanks, fixed.

> Also this comment may be more appropriate for a previous patch.  I'm
> not certain why the new ofctl set-output file option is implemented as
> an appctl command.  That would make sense to me if we needed to change
> the output file as ofctl monitor was running.  It seems to me, that it
> would be a lot cleaner and simpler to make it a command line option.
> My understanding of the use case presented in the series leads me to
> believe that would be sufficient.  I don't feel super strongly about
> it though, so if you have some reason for the current strategy feel
> free to leave it.

It's because the test changes the output file while ofctl monitor is
running.  Well, I guess it changes it to the same name each time, but
it has the desired effect of starting over from empty contents.  (If
it would make you happy I will change the test to use a different name
each time.)



More information about the dev mailing list