[ovs-dev] [PATCH] ovs-ofctl: Clarify that tun_id will not be nonzero unless the key is nonzero

Ben Pfaff blp at nicira.com
Mon Feb 13 05:28:05 UTC 2012


Jesse, I think that Simon is correct, will you ack this patch or apply
it?

Thanks,

Ben.

On Mon, Feb 13, 2012 at 12:31:43PM +0900, Simon Horman wrote:
> The Open vSwtich datapath's GRE implementation does not appear to make a
> distinction between no key present and a zero key present, which appears to
> be consistent with the (other) Linux implementation of GRE. Make this a
> little clearer in the documentation.
> 
> Signed-off-by: Simon Horman <horms at verge.net.au>
> ---
>  utilities/ovs-ofctl.8.in |   10 +++++-----
>  1 files changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/utilities/ovs-ofctl.8.in b/utilities/ovs-ofctl.8.in
> index 1c1b709..ed2ba79 100644
> --- a/utilities/ovs-ofctl.8.in
> +++ b/utilities/ovs-ofctl.8.in
> @@ -666,11 +666,11 @@ digits delimited by colons.
>  .IP \fBtun_id=\fItunnel-id\fR[\fB/\fImask\fR]
>  Matches tunnel identifier \fItunnel-id\fR.  Only packets that arrive
>  over a tunnel that carries a key (e.g. GRE with the RFC 2890 key
> -extension) will have a nonzero tunnel ID.  If \fImask\fR is omitted,
> -\fItunnel-id\fR is the exact tunnel ID to match; if \fImask\fR is
> -specified, then a 1-bit in \fImask\fR indicates that the corresponding
> -bit in \fItunnel-id\fR must match exactly, and a 0-bit wildcards that
> -bit.
> +extension and a nonzero key value) will have a nonzero tunnel ID.
> +If \fImask\fR is omitted, \fItunnel-id\fR is the exact tunnel ID to match;
> +if \fImask\fR is specified, then a 1-bit in \fImask\fR indicates that the
> +corresponding bit in \fItunnel-id\fR must match exactly, and a 0-bit
> +wildcards that bit.
>  .IP
>  In an attempt to be compatible with more switches, \fBovs\-ofctl\fR will
>  prefer to use the ``tunnel ID from cookie'' Nicira extension to NXM.
> -- 
> 1.7.6.3
> 
> _______________________________________________
> dev mailing list
> dev at openvswitch.org
> http://openvswitch.org/mailman/listinfo/dev



More information about the dev mailing list