[ovs-dev] Bug#659685: [PATCH] debian: Do not run "make" if "configure" fails during DKMS build.

[Thomas Goirand]

On 02/14/2012 02:09 AM, Ben Pfaff wrote:
> There is no point in trying to run "make" if "configure" failed.  The
> "make" will fail too and the log will be harder to read.
> 
> CC: Thomas Goirand <zigo at debian.org>
> CC: Simon Horman <horms at verge.net.au>
> Signed-off-by: Ben Pfaff <blp at nicira.com>
> ---
>  debian/dkms.conf.in |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/debian/dkms.conf.in b/debian/dkms.conf.in
> index a6dc316..ae1fc7a 100644
> --- a/debian/dkms.conf.in
> +++ b/debian/dkms.conf.in
> @@ -1,6 +1,6 @@
>  PACKAGE_NAME="openvswitch"
>  PACKAGE_VERSION="__VERSION__"
> -MAKE="./configure --with-linux=/lib/modules/`uname -r`/build ; make -C datapath/linux"
> +MAKE="./configure --with-linux=/lib/modules/`uname -r`/build && make -C datapath/linux"
>  BUILT_MODULE_NAME[0]=openvswitch_mod
>  BUILT_MODULE_NAME[1]=brcompat_mod
>  BUILT_MODULE_LOCATION[0]=datapath/linux/

Hi,

I can confirm that the above fixes the issue.

If you need someone to sponsor the upload of this fix, let me know, and
I'll do that. Or would you accept that I do an NMU, maybe?

Thomas