[ovs-dev] Bug#659685: [PATCH] debian: Do not run "make" if "configure" fails during DKMS build.

Ben Pfaff blp at nicira.com
Tue Feb 14 00:05:00 UTC 2012


On Tue, Feb 14, 2012 at 07:50:23AM +0800, Thomas Goirand wrote:
> On 02/14/2012 07:41 AM, Thomas Goirand wrote:
> > On 02/14/2012 02:09 AM, Ben Pfaff wrote:
> >> -MAKE="./configure --with-linux=/lib/modules/`uname -r`/build ; make -C datapath/linux"
> >> +MAKE="./configure --with-linux=/lib/modules/`uname -r`/build && make -C datapath/linux"
> I just thought about something... Using "uname -r" is wrong by
> definition. Why? Well, simply because you are pretending that the target
> build will use the running kernel version, which is wrong: I well may be
> running kernel 3.1, and want to have a build of the dkms module for 3.2!
> And in fact, that's exactly what I need right now. I'd need that
> openvswitch build some kernel modules for BOTH of my installed kernel,
> eg 3.1 and 3.2, and that, even if I'm running 3.1 right now.

Argh.  This is what I get for applying the downstream Ubuntu patch to
add DKMS support without fully understanding how DKMS works.

OK, patch coming up.





More information about the dev mailing list