[ovs-dev] [PATCH] xenserver: Fix iteration of dictionary

[Ben Pfaff]

On Wed, Feb 15, 2012 at 02:06:04PM +0000, Dominic Curran wrote:
> Fix bug in commit 3249bb907a1dab9b0
> 
> Incorrectly assume that get_all_records_where() returned a list.
> It infact returns a disctionary and the list iteratory needs to change
> to account for this.
> Thanks to Nicira for pointing this out.
> 
> Signed-off-by: Rob Hoes <rob.hoes at citrix.com>
> Acked-by: Dominic Curran <Dominic.curran at citrix.com>

Thank you for the patch.  There is a minor procedural problem here
though: the sign-off is wrong.  If you wrote the patch, then you should
sign off.  If Rob wrote the patch, and you are just posting it, then
there should be a "From: Dominic Curran <gigamuffin at gmail.com>" as the
first line of the body of the message.

Less importantly, according to out-of-band information I have, we should
also have the following at the bottom above the sign-offs:

    NIC-454.
    Reported-by: David Tsai <dtsai at nciira.com>

Thanks,

Ben.