[ovs-dev] [PATCH 1/1] xenserver: Fix iteration of dictionary
Dominic Curran
dominic.curran at citrix.com
Wed Feb 15 17:38:28 UTC 2012
> -----Original Message-----
> From: Ben Pfaff [mailto:blp at nicira.com]
> Sent: 15 February 2012 17:24
> To: Rob Hoes
> Cc: dev at openvswitch.org; Dominic Curran; Rob Hoes
> Subject: Re: [ovs-dev] [PATCH 1/1] xenserver: Fix iteration of
> dictionary
>
> On Wed, Feb 15, 2012 at 05:17:25PM +0000, Rob Hoes wrote:
> > From: Dominic Curran <dominic.curran at citrix.com>
> >
> > Fix bug in commit 3249bb907a1dab9b0
> >
> > Incorrectly assume that get_all_records_where() returned a list.
> > It infact returns a disctionary and the list iteratory needs to
> change
> > to account for this.
> > Thanks to Nicira for pointing this out.
> >
> > NIC-454.
> >
> > Signed-off-by: Rob Hoes <rob.hoes at citrix.com>
> > Reported-by: David Tsai <dtsai at nicira.com>
> > Signed-off-by: Dominic Curran <Dominic.curran at citrix.com>
>
> Now I'm confused. First, Dominic, I understand <gigamuffin at gmail.com>
> to be your email address, but you've attached Rob Hoes's name to it in
> your email headers. Second, who actually wrote this patch? Dominic,
> did you write it or did Rob?
>
> Thanks,
>
> Ben.
I know, I know, I've screwed up. Hang head in shame.
Nicira suggested bug fix.
I implemented/wrote the patch.
RobH has OK'd the change.
I thought 'git send-email' was going to put 'From: Rob Hoes <rob.hoes at citrix.com>' where you told me to put it. I'm sorry. I certainly didn't think it was going to mangle my email with his name.
More information about the dev
mailing list