[ovs-dev] Bug#659685: [PATCH] configure: Try to extract kernel source directory from build Makefile.

[Simon Horman]

On Thu, Feb 16, 2012 at 04:53:35PM -0800, Ben Pfaff wrote:
> On Thu, Feb 16, 2012 at 04:32:57PM -0800, Jesse Gross wrote:
> > On Thu, Feb 16, 2012 at 10:36 AM, Ben Pfaff <blp at nicira.com> wrote:
> > > OVS needs to inspect the headers in the kernel source directory at build
> > > time.  Debian keeps moving the source directory relative to the build
> > > directory and doesn't provide an obvious way to find the source directory,
> > > so in the past we've used some name-based heuristics to essentially guess
> > > where it is.
> > >
> > > This commit introduces a new heuristic that I hope will be more reliable:
> > > extracting the source directory from the Makefile in the build directory.
> > > In Debian's case, it looks like the Makefile generally contains a line of
> > > the form "MAKEARGS := -C <srcdir> O=<outdir>".  This commit extracts the
> > > source directory from that line.
> > >
> > > To avoid regressions this commit retains the older heuristics as fallbacks.
> > >
> > > CC: 659685 at bugs.debian.org
> > > Reported-by: Thomas Goirand <zigo at debian.org>
> > > Signed-off-by: Ben Pfaff <blp at nicira.com>
> > 
> > It seems OK to me.  
> 
> Thanks.  Pushed to master and branch-1.[2345].
> 
> > How do other packages solve this problem?  It
> > seems like we have a particularly bad time.
> 
> I've been unable to locate other modules that do this kind of thing.
> I looked at virtualbox, the nvidia drivers, ndiswrapper,
> xtables-addons.

Curious.

I'm fine with your patch as it seems to improve things.
But it would be nice not to have to jump thorough hoops like this.