[ovs-dev] [PATCH] debian: Fix exit status of openvswitch-switch init script "status" command.

[Justin Pettit]

Looks good to me.

--Justin


On Feb 28, 2012, at 4:32 PM, Ben Pfaff wrote:

> The init script ends with an explicit "exit 0" so nonzero exit codes from
> "ovs-ctl status" were being lost.
> 
> Bug #9714.
> Reported-by: Paul Ingram <paul at nicira.com>
> CC: Sujatha Shetty <sshetty at nicira.com>
> Signed-off-by: Ben Pfaff <blp at nicira.com>
> ---
> I haven't tested this but it looks like an obvious bugfix to me.
> 
> debian/openvswitch-switch.init |    3 ++-
> 1 files changed, 2 insertions(+), 1 deletions(-)
> 
> diff --git a/debian/openvswitch-switch.init b/debian/openvswitch-switch.init
> index 6f08c3f..cb9670c 100755
> --- a/debian/openvswitch-switch.init
> +++ b/debian/openvswitch-switch.init
> @@ -1,6 +1,6 @@
> #! /bin/sh
> #
> -# Copyright (C) 2011 Nicira Networks, Inc.
> +# Copyright (C) 2011, 2012 Nicira Networks, Inc.
> #
> # Licensed under the Apache License, Version 2.0 (the "License");
> # you may not use this file except in compliance with the License.
> @@ -86,6 +86,7 @@ case $1 in
>         ;;
>     status)
>         ovs_ctl status
> +        exit $?
>         ;;
>     force-reload-kmod)
>         start force-reload-kmod
> -- 
> 1.7.2.5
> 
> _______________________________________________
> dev mailing list
> dev at openvswitch.org
> http://openvswitch.org/mailman/listinfo/dev