[ovs-dev] [packet_in 09/13] ofp-util: Don't use ofpbuf in ofputil_packet_in struct.

Ben Pfaff blp at nicira.com
Tue Jan 3 18:12:35 UTC 2012


On Tue, Jan 03, 2012 at 10:05:52AM -0800, Ethan Jackson wrote:
> Here's another version of the patch which takes into account your comments.

Thanks.

You could simplify further by making pktbuf_save() take a pointer and
length instead of a pktbuf.

I see that pktbuf_save() should also start allocating more headroom
for the ofpbufs it creates (later on in this series).  Either that, or
allocate no headroom at all based on the argument that packets that
have already gone to the controller are probably not going to go back
to the controller a second time.



More information about the dev mailing list